We can easily enable the following rules everywhere: - no-dupe-args - no-dupe-keys - no-duplicate-case - no-obj-calls - no-with Also, we can enable in browser/ - no-redeclare - consistent-return There are too many hits for these latter two in toolkit but I didn't want to let that block enabling them in browser/ only.

Comment on attachment 8697327 [details] [diff] [review] Enable rules Review of attachment 8697327 [details] [diff] [review]: ----------------------------------------------------------------- r+++ would review again!

Comment on attachment 8697325 [details] [diff] [review] Fixes some eslint errors/warning to enable more rules Review of attachment 8697325 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/base/content/browser.js @@ +328,5 @@ > var backDisabled = backBroadcaster.hasAttribute("disabled"); > var forwardDisabled = forwardBroadcaster.hasAttribute("disabled"); > if (backDisabled == aWebNavigation.canGoBack) { > if (backDisabled) > + backBroadcaster.removeAttribute('disabled'); I don't understand this change.

(In reply to Marco Bonardo [::mak] from comment #5) > Comment on attachment 8697325 [details] [diff] [review] > Fixes some eslint errors/warning to enable more rules > > Review of attachment 8697325 [details] [diff] [review]: > ----------------------------------------------------------------- > > ::: browser/base/content/browser.js > @@ +328,5 @@ > > var backDisabled = backBroadcaster.hasAttribute("disabled"); > > var forwardDisabled = forwardBroadcaster.hasAttribute("disabled"); > > if (backDisabled == aWebNavigation.canGoBack) { > > if (backDisabled) > > + backBroadcaster.removeAttribute('disabled'); > > I don't understand this change. sorry, I was testing the double-quotes rules and accidentally saved this in the file

Comment on attachment 8697325 [details] [diff] [review] Fixes some eslint errors/warning to enable more rules Review of attachment 8697325 [details] [diff] [review]: ----------------------------------------------------------------- ok, r=me with the quotes fixed

https://hg.mozilla.org/integration/fx-team/rev/54bb45fa0e7d https://hg.mozilla.org/integration/fx-team/rev/f4ce7427347e https://hg.mozilla.org/integration/fx-team/rev/11c67a7b46b5

https://hg.mozilla.org/mozilla-central/rev/54bb45fa0e7d https://hg.mozilla.org/mozilla-central/rev/f4ce7427347e https://hg.mozilla.org/mozilla-central/rev/11c67a7b46b5